Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GR-51623] Use Locale.ROOT instead of Locale.ENGLISH. #8328

Merged
merged 2 commits into from
Feb 12, 2024
Merged

[GR-51623] Use Locale.ROOT instead of Locale.ENGLISH. #8328

merged 2 commits into from
Feb 12, 2024

Conversation

graalvmbot
Copy link
Collaborator

This PR follows up on #8247 and replaces Locale.ENGLISH with the preferred "neutral" Locale.ROOT. In practice it shouldn't make a difference because only the following few languages get special treatment for upper and lower case:

        String lang = locale.getLanguage();
        if (lang == "tr" || lang == "az" || lang == "lt") {
            return toLowerCaseEx(str, value, first, locale, true);
        }

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 7, 2024
@graalvmbot graalvmbot closed this Feb 12, 2024
@graalvmbot graalvmbot deleted the fniephaus/GR-51623/string-to-case-root branch February 12, 2024 19:09
@graalvmbot graalvmbot merged commit ac30d82 into master Feb 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fniephaus fniephaus

Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graalvmbot @fniephaus